Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation for SWS scale #33
Implementation for SWS scale #33
Changes from 14 commits
7619cab
760fb8c
7bc348e
004bbcd
e66d604
cbe5a74
a9ae08f
08aa9f2
0b75de3
124b0fa
2dcc530
5a50f31
7a4e56a
bb41cd1
101fbf8
4724734
ebc95cd
d0b980a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 2 things not OK with the update logic:
ssc.c
shouldn't be updated if there's an error heressc
attributes shouldn't be updated if there is an errorHere's what I'd rather have:
updateContext
toupdate
and follow this signaturefunc (ssc *SoftwareScaleContext) update(u softwareScaleContextUpdate) error