Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce bundle specs version to be semver #114

Merged
merged 2 commits into from
Jun 28, 2018

Conversation

djzager
Copy link
Contributor

@djzager djzager commented Jun 27, 2018

This forces the Bundle Spec's Version to be semver compatible. This PR also moves the responsibility of verifying the bundle version from the registry package to the bundle package.

This was referenced Jun 27, 2018
Copy link
Contributor

@dymurray dymurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job and thanks for including the tests.

@dymurray
Copy link
Contributor

ACK to all the APB PRs in referenced above.

Copy link
Contributor

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to the tests. looks good

@djzager djzager merged commit 78e6a94 into automationbroker:master Jun 28, 2018
@djzager djzager deleted the spec-semver branch June 28, 2018 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants