Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(autoware_universe_utils): introduce managed transform buffer with implicitly defined listener type #9197

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

amadeuszsz
Copy link
Contributor

Description

See parent issue.

Related links

Parent Issue:

How was this PR tested?

See parent issue.

Notes for reviewers

None.

Interface changes

  • has_static_tf_only parameter is not necessary anymore.
  • getTransform now has form getTransform<typename T> (geometry_msgs::msg::TransformStamped, tf2::Transform, Eigen::Matrix4f).
  • getTransform returns std::optional.

Effects on system behavior

See parent issue.

…h implicitly defined listener type

Signed-off-by: amadeuszsz <[email protected]>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) tag:require-cuda-build-and-test labels Oct 30, 2024
Copy link

github-actions bot commented Oct 30, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@amadeuszsz amadeuszsz self-assigned this Oct 30, 2024
@amadeuszsz amadeuszsz added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 30, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 82.85714% with 30 lines in your changes missing coverage. Please review.

Project coverage is 28.98%. Comparing base (03bc2b7) to head (a881d6a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...niverse_utils/src/ros/managed_transform_buffer.cpp 87.07% 13 Missing and 6 partials ⚠️
...und_segmentation/src/ransac_ground_filter/node.cpp 33.33% 0 Missing and 2 partials ⚠️
...ssor/distortion_corrector/distortion_corrector.hpp 60.00% 0 Missing and 2 partials ⚠️
...distortion_corrector/distortion_corrector_node.cpp 0.00% 2 Missing ⚠️
...ng/autoware_pointcloud_preprocessor/src/filter.cpp 33.33% 2 Missing ⚠️
...atenate_data/concatenate_and_time_sync_nodelet.cpp 0.00% 1 Missing ⚠️
...r/src/concatenate_data/concatenate_pointclouds.cpp 0.00% 1 Missing ⚠️
...r/src/time_synchronizer/time_synchronizer_node.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9197      +/-   ##
==========================================
+ Coverage   28.92%   28.98%   +0.06%     
==========================================
  Files        1324     1325       +1     
  Lines      102572   102663      +91     
  Branches    39795    39853      +58     
==========================================
+ Hits        29666    29760      +94     
- Misses      69964    70048      +84     
+ Partials     2942     2855      -87     
Flag Coverage Δ *Carryforward flag
differential 30.48% <82.85%> (?)
total 28.76% <ø> (-0.16%) ⬇️ Carriedforward from a9763cb

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) tag:require-cuda-build-and-test tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant