perf(autoware_universe_utils): introduce managed transform buffer with implicitly defined listener type #9197
CodeScene PR Check
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: +0.13 (7.40 -> 7.53)
- Declining Code Health: 3 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
Details
🚩 Declining Code Health (highest to lowest):
- Complex Conditional managed_transform_buffer.cpp: ManagedTransformBuffer::transformPointcloud
- Excess Number of Function Arguments managed_transform_buffer.cpp: ManagedTransformBuffer::transformPointcloud
- String Heavy Function Arguments managed_transform_buffer.cpp
✅ Improving Code Health:
- Overall Code Complexity filter.cpp
Annotations
Check warning on line 115 in common/autoware_universe_utils/src/ros/managed_transform_buffer.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Conditional
ManagedTransformBuffer::transformPointcloud has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
Check warning on line 132 in common/autoware_universe_utils/src/ros/managed_transform_buffer.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Excess Number of Function Arguments
ManagedTransformBuffer::transformPointcloud has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check warning on line 1 in common/autoware_universe_utils/src/ros/managed_transform_buffer.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: String Heavy Function Arguments
In this module, 42.9% of all arguments to its 13 functions are strings. The threshold for string arguments is 39.0%. The functions in this file have a high ratio of strings as arguments. Avoid adding more.
Check notice on line 1 in perception/autoware_ground_segmentation/src/ransac_ground_filter/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 4.17 to 4.36, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 4.15 to 4.25, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Check notice on line 1 in sensing/autoware_pointcloud_preprocessor/src/filter.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 4.42 to 4.25, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.