Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_velocity_planner)!: remove stop_reason #9452

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Nov 25, 2024

Description

StopReason interface will be deprecated, so remove it from behavior_velocity_planner

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

~/behavior_velocity/***/stop_reason disappears

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 25, 2024
Copy link

github-actions bot commented Nov 25, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 10.25641% with 35 lines in your changes missing coverage. Please review.

Project coverage is 29.46%. Comparing base (9fac554) to head (c14b8ed).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
..._behavior_velocity_blind_spot_module/src/scene.cpp 0.00% 7 Missing ⚠️
...ior_velocity_no_drivable_lane_module/src/scene.cpp 0.00% 7 Missing ⚠️
...elocity_virtual_traffic_light_module/src/scene.cpp 0.00% 6 Missing ⚠️
...ity_intersection_module/src/scene_intersection.cpp 0.00% 4 Missing ⚠️
..._velocity_crosswalk_module/src/scene_crosswalk.cpp 0.00% 2 Missing ⚠️
...havior_velocity_traffic_light_module/src/scene.cpp 0.00% 2 Missing ⚠️
...ction_module/src/scene_merge_from_private_road.cpp 0.00% 1 Missing ⚠️
...topping_area_module/src/scene_no_stopping_area.cpp 0.00% 1 Missing ⚠️
..._behavior_velocity_speed_bump_module/src/scene.cpp 0.00% 1 Missing ⚠️
...e_behavior_velocity_stop_line_module/src/scene.cpp 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9452      +/-   ##
==========================================
- Coverage   29.48%   29.46%   -0.03%     
==========================================
  Files        1443     1449       +6     
  Lines      108683   108575     -108     
  Branches    41540    41439     -101     
==========================================
- Hits        32044    31988      -56     
+ Misses      73519    73465      -54     
- Partials     3120     3122       +2     
Flag Coverage Δ *Carryforward flag
differential 23.26% <10.25%> (?)
total 29.48% <ø> (-0.01%) ⬇️ Carriedforward from 9fac554

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin disabled auto-merge December 2, 2024 03:29
@soblin soblin force-pushed the feat/bvp-intersection/remove-stop-reason branch from 72730cf to ca39a35 Compare December 2, 2024 03:29
@soblin soblin force-pushed the feat/bvp-intersection/remove-stop-reason branch from ca39a35 to c14b8ed Compare December 2, 2024 07:55
@soblin soblin enabled auto-merge (squash) December 2, 2024 09:21
@mitsudome-r
Copy link
Member

The clang-tidy is failing due to memory issue, but we have tested locally that there is no clang-tidy error shows up with this PR.

@mitsudome-r mitsudome-r merged commit 7b7db7a into autowarefoundation:main Dec 2, 2024
29 of 32 checks passed
@mitsudome-r mitsudome-r deleted the feat/bvp-intersection/remove-stop-reason branch December 2, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants