-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Wayland support based on wl-clipboard-rs #65
base: master
Are you sure you want to change the base?
Conversation
so clients without wayland don't use it
Hey! Just noticed this PR. :) This way of checking for primary selection support isn't entirely correct (it would return an error if only Also (as pointed out in #34) I'd like to note that the |
I wrote this because I switched from Alacritty to Kitty for Wayland clipboard support; since Alacritty is a windowed application with a surface, it seems I need to add a
|
Yeah, the differences are roughly:
|
This latest commit updates the dependency on In addition, copies to both the primary selection and regular clipboard are now atomic. Previously, a selection was first copied to the primary selection and then to the regular clipboard. |
smithay-clipboard 0.1 requires smithay-client-toolkit 0.5, which requires wayland-client 0.22. Travis CI build was failing because the toolchain was grabbing a different version of wayland-client instead of making the sensible decision of picking whatever already worked with smithay-clipboard.
Great! Just three things:
|
@Gregory-Meyer Hey, it looks like this is really close to being mergeable. Can we get it finished up? If you're not able to finish, I may be able to pick it up. |
Any progress on this? |
I created #71 to address some of the feedback here, but it seems like this repo may have been abandoned, so I'm not sure what the best path forward is. I would love to see this make it back into crates.io. |
This pull request adds
mod wayland_clipboard
and implementsWaylandClipboardContext
within.wl-clipboard-rs
does most of the heavy lifting here, butWaylandClipboardContext
has the following characteristics:Implementing a
CompositeClipboardContext
should be fairly simple; first attempt to create aWaylandClipboardContext
, then attempt to create anX11ClipboardContext
if the Wayland implementation fails for some reason or another.