Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish Wayland support with wl-clipboard-rs #71

Closed
wants to merge 11 commits into from
Closed

Finish Wayland support with wl-clipboard-rs #71

wants to merge 11 commits into from

Conversation

showermat
Copy link

This pull request finishes the work abandoned in #65 adding Wayland clipboard support via wl-clipboard-rs.

Gregory-Meyer and others added 11 commits March 14, 2019 21:15
@Gregory-Meyer
add wayland-client dependency
998dc45
@Gregory-Meyer
force dlopen for wayland-client
811df0c 
so clients without wayland don't use it
@Gregory-Meyer
add method stubs for WaylandClipboardContext
fb30684
@Gregory-Meyer
add wayland-client dep and mod wayland_clipboard
9a15511
@Gregory-Meyer
add failure and wl-clipboard-rs dependencies
b46fea2
@Gregory-Meyer
use wl-clipboard-rs implementation
299d78c
@Gregory-Meyer
remove debugging thread::sleep call
1295c1a
@Gregory-Meyer
document mod wayland_clipboard
648c6fa
@Gregory-Meyer
add support for clipboards not using data-control
4833dda
@Gregory-Meyer
manually specify wayland-client dep as 0.22
ef569ec 
smithay-clipboard 0.1 requires smithay-client-toolkit 0.5, which requires
wayland-client 0.22. Travis CI build was failing because the toolchain was
grabbing a different version of wayland-client instead of making the sensible
decision of picking whatever already worked with smithay-clipboard.
@showermat
don't error if a seat is unavailable on context creation
330f9b8
@showermat showermat mentioned this pull request Nov 24, 2019
Open
@YaLTeR
Copy link

YaLTeR commented Dec 13, 2019

Hey, wl-clipboard-rs 0.4.0 has just been released with an important change: background mode no longer forks (instead, it spawns a thread), as forking is unsafe in multi-threaded applications, and can cause a number of surprising effects. Could you please update the PR to use 0.4 and see if it works fine? Thanks!

@showermat
Copy link
Author

Thanks for the update. I never actually used the Wayland support in this crate because I was waiting for it to be merged. My minimal testing just now doesn't reveal any changes in behavior. set_contents works fine (until program exit, which I believe is intended), but get_contents always returns an empty string. That's true in version 0.3 as well, so I assume it's an issue with my setup. I'm afraid that as long as it doesn't look like this is going to get merged, I don't really have the motivation to debug this further.

@showermat showermat closed this by deleting the head repository Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@showermat @YaLTeR @Gregory-Meyer