Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows packer): install_git variable and WinRM timeout adjusted to 15m #309

Closed
wants to merge 1 commit into from

Conversation

henrykie
Copy link
Contributor

Issue number:
Closes #308

Summary

Creates install_git variable and defaults to True.

Changes

Please provide a summary of what's being changed

See summary.

User experience

Please share what the user experience looks like before and after this change

Users can disable Git installation on Windows build agent AMI with a variable.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented
Is this a breaking change?

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created might not be successful.

@henrykie henrykie requested a review from a team as a code owner September 23, 2024 22:11
@henrykie henrykie added the packer Work related to Packer templates label Sep 23, 2024
@henrykie henrykie requested a review from kylesomers September 24, 2024 17:31
@henrykie henrykie changed the title fix(windows packer): Added install_git variable back fix(windows packer): install_git variable and WinRM timeout adjusted to 15m Sep 25, 2024
@jorisdon
Copy link
Contributor

jorisdon commented Sep 26, 2024

The INSTALL_GIT environment variable is not actually used, so I think we should remove it instead. I've submitted a PR that does so (and fixes a few more issues): #318

@jorisdon
Copy link
Contributor

Closing in favor of #318 which has an alternative fix, and has the WinRM timeout change incorporated into it as well.

@jorisdon jorisdon closed this Sep 26, 2024
@henrykie henrykie deleted the quickfix/windows-packer-git branch September 29, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packer Work related to Packer templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Windows Build Agent Packer fails due to missing install_git variable
2 participants