-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve stability of build agent packer scripts, remove variables that aren't needed #318
Conversation
…voids a potential installation issue where packages can't be found in /var/cache or a lock can't be acquired.
…d setup script, so octobuild setup doesn't have to (it can fail to acquire the dpkg lock)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Include the WinRM timeout configuration from #309 in this PR then we can close out that one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving.
We should look to combine these AMI builds under a single template to reduce duplicate config. Packer is build to provision multiple AMIs off various sources in one template. Not a priority.
…pment-toolkit into jorisdon/fix-build-agents-packer
…meout to 15 minutes, remove packer variables that aren't needed (#318)
…meout to 15 minutes, remove packer variables that aren't needed (aws-games#318)
Issue number: Closes #308
Summary
Changes
This PR does two things:
dnf
instead ofyum
(on Amazon Linux 2023).User experience
Only change in user experience is that there should now be fewer packer build failures.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
I checked, but documentation changes are not necessary for this PR.
Is this a breaking change?
NoAcknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created might not be successful.