Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uploading the replay worker logs to s3 #133

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Conversation

DevanathanSabapathy1
Copy link
Contributor

Issue #, if available:

Currently we only upload the main thread logs to s3. When customer faces issues looking at the file does not give us a lot of information.
I modified the code to upload the worker logs to s3 too. This will help us analyze customer issues more thoroughly.

Description of changes:

now along with replay_log.zip file in s3 we will also have replay_worker_log.zip ( which will have the files replay_worker-0, replay_worker-1... etc)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

core/replay/replay.py Outdated Show resolved Hide resolved
@jiezhen-chen jiezhen-chen merged commit 9673e86 into main Nov 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants