Fixes issue where Ki,Mi,Gi,Ti,Pi behave like K,KB etc instead of KiB. #1827
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where Ki,Mi,Gi,Ti,Pi behave like K,KB etc instead of KiB.
Fixes #1618
As described in issue 1618, the Ki,Mi,etc units do not behave as expected. The code in parse.c explicitly handles K,KB and KiB, but not Ki, this results in Ki being implicitly handled by the "K" check. This commit adds explicit handling of Ki,Mi, etc to match the behavior of KiB, MiB, etc.
This change also brings the behaviour in line with the documentation, though the examples have incorrect numbers for TB and have duplicated entries between kb_base=1000 and kb_base=1024.
Sean Ashton [email protected]