Closes #3821: Make the # link stays at the current page

[BaoNguyen09]

Description

Fix: Make the # link stays at the current page

Related issues

Closes #3821

How to test

1. Add a card to a page
2. Add # to the link URL field
3. Save
4. Observe the link redirecting the user to the current page

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

• Patch release changes
  • Bug fix
  • Accessibility, performance, or security improvement
  • Critical institutional link or brand change
  • Adding experimental module
  • Update experimental module
• Minor release changes
  • New feature
  • Breaking or visual change to existing behavior
  • Upgrade experimental module to stable
  • Enable existing module by default or database update
  • Non-critical brand change
  • New internal API or API improvement with backwards compatibility
  • Risky or disruptive cleanup to comply with coding standards
  • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
• Other or unknown
  • Other or unknown

Drupal core

• Patch release changes
  • Security update
  • Patch level release (non-security bug-fix release)
  • Patch removal that's no longer necessary
• Minor release changes
  • Major or minor level update
• Other or unknown
  • Other or unknown

Drupal contrib projects

• Patch release changes
  • Security update
  • Patch or minor level update
  • Add new module
  • Patch removal that's no longer necessary
• Minor release changes
  • Major level update
• Other or unknown
  • Other or unknown

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.
• My change requires release notes.

[bberndt-uaz]

This works! 👍 From a quick test in Probo, entering #heading in the Card Link URL field results in a link that looks like this:

<a href="/brian-test-page#heading" class="btn-block">Card link to heading</a>

As an alternative, we could consider skipping the addition of the path and we could just use the anchor exactly as entered by the user. In that case, we could set $link_url to something like Url::fromUri(urldecode('internal:' . $item->link_uri)). Then the resulting href for the link would include only the anchor tag, matching how it currently works when creating an anchor link in a text paragraph:

<a href="#heading" class="btn-block">Card link to heading</a>

[joshuasosa]

Good improvement that works. Could look into the suggested alternative. I also see that the Link field formatter works fine with these kinds of links. Could investigate how the field formatter works (e.g., the 'Where' field on Event type works properly).