Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve BigInteger and BigSerial support #101

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Improve BigInteger and BigSerial support #101

merged 1 commit into from
Jun 12, 2024

Conversation

joshbwlng
Copy link
Contributor

@joshbwlng joshbwlng commented May 7, 2024 •
edited
Loading

Change-type: major

  • Reviving the work started with Big int parsing #71
  • Setting this as a major due to changing types from number to bigint

@joshbwlng joshbwlng self-assigned this May 7, 2024
@joshbwlng joshbwlng force-pushed the joshbwlng/big-int branch 4 times, most recently from 1070e81 to 61d5878 Compare May 8, 2024 04:55
@joshbwlng joshbwlng requested review from Page- and a team May 8, 2024 05:29
@joshbwlng joshbwlng marked this pull request as ready for review May 8, 2024 22:30
fisehara
fisehara reviewed May 31, 2024
View reviewed changes
src/types/big-integer.ts Outdated Show resolved Hide resolved
test/Big Integer.ts Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there also be a test case for the fetch branch which results in the exeception: Fetched bigint is not valid: ' + typeof data

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a test case

Page-
Page- reviewed May 31, 2024
View reviewed changes
src/types/big-integer.ts Outdated Show resolved Hide resolved
@balena-io-modules balena-io-modules deleted a comment from fisehara Jun 4, 2024
@joshbwlng joshbwlng marked this pull request as draft June 4, 2024 01:36
@joshbwlng joshbwlng requested review from fisehara and Page- June 4, 2024 01:36
@joshbwlng joshbwlng force-pushed the joshbwlng/big-int branch from 952f52b to db2010e Compare June 9, 2024 22:14
@joshbwlng joshbwlng force-pushed the joshbwlng/big-int branch from db2010e to b9b1fc3 Compare June 12, 2024 22:02
@joshbwlng joshbwlng marked this pull request as ready for review June 12, 2024 22:37
@joshbwlng joshbwlng merged commit e9fe955 into master Jun 12, 2024
49 checks passed
@joshbwlng joshbwlng deleted the joshbwlng/big-int branch June 12, 2024 22:37
@joshbwlng joshbwlng mentioned this pull request Jun 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisehara fisehara fisehara approved these changes

@thgreasi thgreasi Awaiting requested review from thgreasi

@otaviojacobi otaviojacobi Awaiting requested review from otaviojacobi

@Page- Page- Awaiting requested review from Page-

Assignees

@joshbwlng joshbwlng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshbwlng @Page- @fisehara