Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI without building runfiles links #2340

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

UebelAndre
Copy link
Collaborator

No description provided.

@UebelAndre
Copy link
Collaborator Author

I created bazelbuild/bazel#20577 to track the current failures in CI.

@UebelAndre UebelAndre force-pushed the norunfiles branch 2 times, most recently from 1cc9350 to d2ea1dd Compare December 18, 2023 16:44
@UebelAndre UebelAndre marked this pull request as ready for review December 5, 2024 18:51
@UebelAndre UebelAndre enabled auto-merge December 5, 2024 18:53
@UebelAndre UebelAndre added this pull request to the merge queue Dec 5, 2024
Merged via the queue into bazelbuild:main with commit b27bf62 Dec 5, 2024
4 checks passed
@UebelAndre UebelAndre deleted the norunfiles branch December 5, 2024 21:49
UebelAndre added a commit that referenced this pull request Dec 6, 2024
github-merge-queue bot pushed a commit that referenced this pull request Dec 6, 2024
Reverts #2340

It seems like there were cache hits that dodged an important issue
```
bazel coverage //…
```
```
================================================================================
FAIL: //test/unit/crate_name:default/crate-name-test (see /private/var/tmp/_bazel_user/76282c66b0dfe3c5cb9a230bdc913a52/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/test/unit/crate_name/default/crate-name-test/test.log)
INFO: From Testing //test/unit/crate_name:default/crate-name-test:
==================== Test output for //test/unit/crate_name:default/crate-name-test:

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

/private/var/tmp/_bazel_user/76282c66b0dfe3c5cb9a230bdc913a52/sandbox/darwin-sandbox/3262/execroot/_main/bazel-out/darwin_arm64-opt-exec-ST-d57f47055a04/bin/external/bazel_tools~remote_coverage_tools_extension~remote_coverage_tools/Main: Cannot locate runfiles directory. (Set $JAVA_RUNFILES to inhibit searching.)
```
This flag still cannot be flipped without breaking coverage it seems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants