Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External path dependencies work #3025

Merged
merged 10 commits into from
Dec 5, 2024
2 changes: 1 addition & 1 deletion crate_universe/src/context.rs
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ pub(crate) struct Context {
/// A list of crates visible to this bazel module.
pub(crate) direct_dev_deps: BTreeSet<CrateId>,

/// A list of [patch] entries from the Cargo.lock file which were not used in the resolve.
/// A list of `[patch]`` entries from the Cargo.lock file which were not used in the resolve.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// A list of `[patch]`` entries from the Cargo.lock file which were not used in the resolve.
/// A list of `[patch]` entries from the Cargo.lock file which were not used in the resolve.

// TODO: Remove the serde(default) after this has been released for a few versions.
// This prevents previous lockfiles (from before this field) from failing to parse with the current version of rules_rust.
// After we've supported this (so serialised it in lockfiles) for a few versions,
Expand Down
2 changes: 1 addition & 1 deletion crate_universe/src/metadata/metadata_annotation.rs
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ pub(crate) struct LockfileAnnotation {
/// A mapping of crates/packages to additional source (network location) information.
pub(crate) crates: BTreeMap<PackageId, SourceAnnotation>,

/// A list of [patch] entries from the Cargo.lock file which were not used in the resolve.
/// A list of `[patch]`` entries from the Cargo.lock file which were not used in the resolve.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// A list of `[patch]`` entries from the Cargo.lock file which were not used in the resolve.
/// A list of `[patch]` entries from the Cargo.lock file which were not used in the resolve.

pub(crate) unused_patches: BTreeSet<cargo_lock::Dependency>,
}

Expand Down
Loading