Added bzlmod support to all extension rules. #3037
Conversation
UebelAndre
force-pushed
the
bzlmod-ext
branch
10 times, most recently
from
3db9532 to
4e77e69
Compare
| - "//..." | ||
| # TODO: https://github.com/bazelbuild/rules_rust/issues/3039 |
UebelAndre
force-pushed
the
bzlmod-ext
branch
from
4e77e69 to
1aadb5b
Compare
| @@ -1,6 +1,7 @@ | |||
| """Definitions for loading transitive `@rules_rust//proto` dependencies""" | |||
|
|
|||
| load("@bazel_features//:deps.bzl", "bazel_features_deps") | |||
| load("@com_google_protobuf//:protobuf_deps.bzl", "protobuf_deps") | |||
There was a problem hiding this comment.
why does prost require all these protobuf dependencies now? I thought the point of it was that it doesn't?
There was a problem hiding this comment.
I added this because when I updated protobuf I started getting tons of load errors for random external repositories. If there’s a way to avoid this I’m happy to reduce the amount of forced dependencies!
There was a problem hiding this comment.
I have no idea sorry. :( I wonder how it worked before though?
There was a problem hiding this comment.
At a glance it seems like protobuf just started adding more dependencies expecting bzlmod to hide that from users 😞
There was a problem hiding this comment.
So updating and pulling in all those changes that introduced new forced dependencies introduced the need for these extra dependencies.
Additional Changes:
rules_nodejsforrules_rust_wasm_bindgenwill no longer tested and will be dropped unless bzlmod support is added for the originalbazel_build_rules_nodejsrules.rules_rust_bindgenupdated default clang version to 17.0.3 to match bzlmod available version.rules_rust_prostupdated protobuf version tov28.3Relates to: