Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test to ensure extension rules pin the right rules_rust version #3052

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

UebelAndre
Copy link
Collaborator

@UebelAndre UebelAndre commented Dec 6, 2024

A test will now fail if the version is not updated in the extension rules.

==================== Test output for //test/bzlmod:bzl_ext_version_test:

running 1 test
test module_bzl_has_correct_version ... FAILED

failures:

---- module_bzl_has_correct_version stdout ----
    name = "rules_rust",
thread 'module_bzl_has_correct_version' panicked at external/rules_rust~/test/bzl_version/bzl_ext_version_test.rs:76:5:
assertion `left == right` failed: Core rules_rust and the dependency for the current module are out of sync.
  left: "0.55.0"
 right: "0.54.1"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    module_bzl_has_correct_version

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

@UebelAndre UebelAndre marked this pull request as ready for review December 6, 2024 00:11
@UebelAndre UebelAndre mentioned this pull request Dec 6, 2024
@UebelAndre UebelAndre force-pushed the bzlmod branch 2 times, most recently from 0d1b7c2 to 7e76ef2 Compare December 6, 2024 00:51
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@UebelAndre UebelAndre added this pull request to the merge queue Dec 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 6, 2024
@UebelAndre UebelAndre added this pull request to the merge queue Dec 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 6, 2024
@UebelAndre UebelAndre added this pull request to the merge queue Dec 6, 2024
Merged via the queue into bazelbuild:main with commit 456788d Dec 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants