Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added global setting for cargo_build_script.use_default_shell_env #3065

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

UebelAndre
Copy link
Collaborator

This introduces the global setting @rules_rust//cargo/settings:use_default_shell_env for controlling whether or not cargo_build_script targets use ctx.actions.run.use_default_shell_env as well as crate_universe plumbing to explicitly enable or disable this for crates.

@ParkMyCar
Copy link
Contributor

This looks great to me, thanks @UebelAndre!

@UebelAndre UebelAndre marked this pull request as ready for review December 12, 2024 04:32
@UebelAndre UebelAndre enabled auto-merge December 12, 2024 16:46
@UebelAndre UebelAndre added this pull request to the merge queue Dec 12, 2024
Merged via the queue into bazelbuild:main with commit 1352e43 Dec 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants