Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BCR presubmit pipeline #3082

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Fix BCR presubmit pipeline #3082

merged 2 commits into from
Dec 11, 2024

Conversation

UebelAndre
Copy link
Collaborator

Hopefully this resolves the following: https://buildkite.com/bazel/bcr-presubmit/builds/9302#0193b38a-65b5-4be1-91b6-138d4ab9cc90

ERROR: The test module directory does not exist in the source archive: /Users/buildkite/builds/bk-macos-arm64-0n05/bazel-org-repo-root/output/extensions/bindgen/extensions/bindgen
Traceback (most recent call last):
  File "/Users/buildkite/builds/bk-macos-arm64-0n05/bazel/bcr-presubmit/bcr_presubmit.py", line 537, in <module>
    sys.exit(main())
             ^^^^^^
  File "/Users/buildkite/builds/bk-macos-arm64-0n05/bazel/bcr-presubmit/bcr_presubmit.py", line 528, in main
    repo_location, config_file = prepare_test_module_repo(args.module_name, args.module_version, args.overwrite_bazel_version)
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildkite/builds/bk-macos-arm64-0n05/bazel/bcr-presubmit/bcr_presubmit.py", line 269, in prepare_test_module_repo
    error("The test module directory does not exist in the source archive: %s" % test_module_root)
  File "/Users/buildkite/builds/bk-macos-arm64-0n05/bazel/bcr-presubmit/bcr_presubmit.py", line 58, in error
    raise BcrPipelineException("BCR Presubmit failed!")
BcrPipelineException: BCR Presubmit failed!
🚨 Error: The command exited with status 1
^^^ +++

My assumption is that module_path is an extension of where the presubmit yaml exists relative to the root one. So this should finally enable CI to run in th eright place with the correct dependency.

@UebelAndre UebelAndre marked this pull request as ready for review December 11, 2024 06:55
@UebelAndre UebelAndre enabled auto-merge December 11, 2024 06:55
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@UebelAndre UebelAndre added this pull request to the merge queue Dec 11, 2024
Merged via the queue into bazelbuild:main with commit c77ab04 Dec 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants