Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[N/A] bugfix: give new xacro arguments default values #521

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

khughes-bdai
Copy link
Collaborator

@khughes-bdai khughes-bdai commented Nov 6, 2024

Change Overview

fixes an issue where new gripperless arguments needed to be specified for loading the arm URDF. now if they aren't specified, defaults are used instead of throwing an error.

Testing Done

  • standalone arm URDF can be loaded properly if these arguments aren't specifically set

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @khughes-bdai and the rest of your teammates on Graphite Graphite

Copy link
Collaborator Author

khughes-bdai commented Nov 6, 2024

Merge activity

  • Nov 6, 1:07 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 6, 1:07 PM EST: A user merged this pull request with Graphite.

@khughes-bdai khughes-bdai merged commit 3d23f53 into main Nov 6, 2024
4 checks passed
@khughes-bdai khughes-bdai deleted the khughes/urdf_bugfix branch November 6, 2024 18:07
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11709131101

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.053%

Totals Coverage Status
Change from base Build 11685611656: 0.0%
Covered Lines: 1939
Relevant Lines: 3798

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants