[SW-1106] using custom launch actions from synchros2 #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcappellari-bdai
force-pushed
the
SW-1106-use-the-new-launch-actions-in-the-spot-ros-2-repo
branch
from
07bef23 to
9c3113c
Compare
Pull Request Test Coverage Report for Build 12402015250Details
💛 - Coveralls |
tcappellari-bdai
requested review from
METEORITENMAX,
jbarry-bdai,
amessing-bdai,
mpickett-bdai,
bhung-bdai and
khughes-bdai
as code owners
|
There are a bunch of boolean launch args related to image publishing defined here https://github.com/bdaiinstitute/spot_ros2/blob/main/spot_driver/spot_driver/launch/spot_launch_helpers.py & imported into the main launchfiles that could also benefit from this |
jcarpinelli-bdai
approved these changes
Dec 19, 2024
tcappellari-bdai
force-pushed
the
SW-1106-use-the-new-launch-actions-in-the-spot-ros-2-repo
branch
from
c5101b3 to
e46d633
Compare
tcappellari-bdai
deleted the
SW-1106-use-the-new-launch-actions-in-the-spot-ros-2-repo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Modifying the launch files to use the custom launch actions from
synchros2(formerlybdai_ros2_wrappers)Testing Done
driver and examples run as expected
Please create a checklist of tests you plan to do and check off the ones that have been completed successfully. Ensure that ROS 2 tests use
domain_coordinatorto prevent port conflicts. Further guidance for testing can be found on the ros utilities wiki.