bevy_audio: Apply #![deny(clippy::allow_attributes, clippy::allow_attributes_without_reason)]

[LikeLakers2]

Objective

• Deny the clippy::allow_attributes and clippy::allow_attributes_without_reason lints #17111

Solution

Set the clippy::allow_attributes and clippy::allow_attributes_without_reason lints to deny, and bring bevy_audio in line with the new restrictions.

No code changes have been made - except if a lint that was previously allow(...)'d could be removed via small code changes. For example, unused_variables can be handled by adding a _ to the beginning of a field's name.

Testing

cargo clippy and cargo test --package bevy_audio were run, and no errors were encountered.

[LikeLakers2]

I'm gonna be honest: I have NO idea what's happening with rustc's linter in this file. It's marking a deprecated item's definition as a use of a deprecated item, and it's marking the impls for that deprecated item as a use of that deprecated item.

But I tried my best to silence the lints, while simultaneously changing all allows to expects, and giving them all reason = "...".

So I hope the comment atop AudioSourceBundle and the module-wide expect are okay. They were the best I could do without straight-up removing the struct - which, frankly, I'm not sure if that's a good idea in the middle of 0.15.

[LikeLakers2]

I've figured it out - it's the #[derive(Bundle)] placed atop AudioSourceBundle. I've updated the comment atop AudioSourceBundle to reflect these findings.

I consider this to be a rustc issue, and hence don't want to try to change the Bundle derive to include #[allow(deprecated)]. However, I have written a bug report for this:

• Impls for deprecated structs/enums from within the same crate trigger a "use of deprecated struct/enum" warning rust-lang/rust#135065

[BenjaminBrienen]

I disagree with your interpretation of rustc's deprecation behavior. An impl is a usage. I think this should be blocked on #16338, which would clean-up this changeset.

[LikeLakers2]

@BenjaminBrienen Ok. Just notify me when that PR is merged and I'll update this PR.

[LikeLakers2]

This PR is blocked on #16338 per Benjamin's request. Once that is merged, I will fix any conflicts and mark it as ready to merge.