Matchmaking starts autohost #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is going to come handy when something needs an autohost (like matchmaking)
More setup required, so centralise the logic
This ensure that the each player stays in control of their domain, so that the matchmaking related function don't need to query anything from the players.
The same mechanism is going to be used for the player process
And also, only ignore messages that are maps, so that we don't ignore the valid messages like timeouts.
Instead of just the ID. This allow to pass the correct player ID when constructing start script.
geekingfrog
force-pushed
the
matchmaking-starts-autohost
branch
from
fbee762 to
a720e98
Compare
geekingfrog
commented
Nov 19, 2024
| @@ -105,11 +141,76 @@ defmodule Teiserver.Autohost.TachyonHandler do | |||
| {:stop, :normal, 1000, [{:text, resp}], state} | |||
| end | |||
|
|
|||
| # Generic handler for when a response arrives too late | |||
There was a problem hiding this comment.
I am planning to refactor the transport bits, so that this logic about awaiting for the response and timeout management will be centralised and abstracted out of the Autohost and Player modules.
geekingfrog
commented
Nov 19, 2024
| @@ -120,4 +216,29 @@ defmodule Teiserver.Matchmaking.PairingRoom do | |||
|
|
|||
| {:stop, :normal, state} | |||
| end | |||
|
|
|||
| @spec hardcoded_start_script(state()) :: Teiserver.Autohost.start_script() | |||
| defp hardcoded_start_script(state) do | |||
There was a problem hiding this comment.
obviously, this is temporary, but we first need to put some thoughts behind assets management.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration with recoil-host
matchmaking-smol.mp4
I've added a few comments after this video was recorded.