-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matchmaking starts autohost #529
Merged
L-e-x-o-n
merged 18 commits into
beyond-all-reason:master
from
geekingfrog:matchmaking-starts-autohost
Nov 24, 2024
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
e28d14b
Format
geekingfrog a2ba74d
Add `list` operation for autohosts
geekingfrog 9646e82
Kick players out when no autohost available
geekingfrog 6803f9d
Chore: refine typespec: non empty list of member for team
geekingfrog 0b0a218
Generate test autohost name if not provided
geekingfrog afb8938
Send start script when all players are ready
geekingfrog 1aab0bd
Refactor: helper test function to ready up
geekingfrog e576cff
Refactor: separate tests for matchmaking with autohost
geekingfrog 6f01506
Propagate autohost errors to clients
geekingfrog 58f84c2
Player submit data when readying up
geekingfrog 5d4a340
Refactor: centralize the type for pending responses
geekingfrog 1d412f3
Timeout autohost if response is too late
geekingfrog fc68eb5
Send start battle message to players
geekingfrog 7559cb4
Reset player state when match starts
geekingfrog 3846a82
Less verbose logging when things terminate normally
geekingfrog e64a6b2
Handle response timeouts
geekingfrog dcf4f7f
Store player struct in session
geekingfrog a720e98
Remove player from a queue when disbanding pairing
geekingfrog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am planning to refactor the transport bits, so that this logic about awaiting for the response and timeout management will be centralised and abstracted out of the Autohost and Player modules.