Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(payment): PI-1546 Refactor the existing moneris payment strate… #2716

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bc-sebastianszafraniec
Copy link
Contributor

@bc-sebastianszafraniec bc-sebastianszafraniec commented Oct 29, 2024

…gy in Checkout SDK to use the new checkout payment integration JS API

What?

Create Moneris package in checkout-sdk-js and move to it Moneris payment strategy.

Why?

For better separation between payment integrations and core Checkout SDK

Testing / Proof

Tested manually
Zrzut ekranu 2024-10-31 o 10 57 22

Nagranie.z.ekranu.2024-10-29.o.12.05.16.mov

@bigcommerce/team-checkout @bigcommerce/team-payments

…gy in Checkout SDK to use the new checkout payment integration JS API
Copy link
Contributor

@bc-dronov bc-dronov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! May I ask you to attach test coverage screenshot please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants