Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(payment): PI-1546 Refactor the existing moneris payment strate… #2716

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions packages/core/src/payment/create-payment-strategy-registry.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ import {
SpamProtectionActionCreator,
SpamProtectionRequestSender,
} from '../spam-protection';
import { StoreCreditActionCreator, StoreCreditRequestSender } from '../store-credit';

import createPaymentStrategyRegistryV2 from './create-payment-strategy-registry-v2';
import PaymentActionCreator from './payment-action-creator';
Expand Down Expand Up @@ -56,7 +55,6 @@ import {
import { CBAMPGSPaymentStrategy, CBAMPGSScriptLoader } from './strategies/cba-mpgs';
import { ConvergePaymentStrategy } from './strategies/converge';
import { MasterpassPaymentStrategy, MasterpassScriptLoader } from './strategies/masterpass';
import { MonerisPaymentStrategy } from './strategies/moneris';
import { OpyPaymentStrategy, OpyScriptLoader } from './strategies/opy';
import { PaypalExpressPaymentStrategy, PaypalScriptLoader } from './strategies/paypal';
import {
Expand Down Expand Up @@ -94,9 +92,6 @@ export default function createPaymentStrategyRegistry(
new OrderRequestSender(requestSender),
checkoutValidator,
);
const storeCreditActionCreator = new StoreCreditActionCreator(
new StoreCreditRequestSender(requestSender),
);
const paymentHumanVerificationHandler = new PaymentHumanVerificationHandler(
createSpamProtection(createScriptLoader()),
);
Expand Down Expand Up @@ -242,18 +237,6 @@ export default function createPaymentStrategyRegistry(
),
);

registry.register(
PaymentStrategyType.MONERIS,
() =>
new MonerisPaymentStrategy(
hostedFormFactory,
store,
orderActionCreator,
paymentActionCreator,
storeCreditActionCreator,
),
);

registry.register(
PaymentStrategyType.OPY,
() =>
Expand Down
7 changes: 0 additions & 7 deletions packages/core/src/payment/payment-request-options.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import {
} from './strategies/braintree';
import { DigitalRiverPaymentInitializeOptions } from './strategies/digitalriver';
import { MasterpassPaymentInitializeOptions } from './strategies/masterpass';
import { MonerisPaymentInitializeOptions } from './strategies/moneris';
import { OpyPaymentInitializeOptions } from './strategies/opy';
import { PaypalExpressPaymentInitializeOptions } from './strategies/paypal';
import { SquarePaymentInitializeOptions } from './strategies/square';
Expand Down Expand Up @@ -78,12 +77,6 @@ export interface BasePaymentInitializeOptions extends PaymentRequestOptions {
*/
masterpass?: MasterpassPaymentInitializeOptions;

/**
* The options that are required to initialize the Moneris payment method.
* They can be omitted unless you need to support Moneris.
*/
moneris?: MonerisPaymentInitializeOptions;

/**
* The options that are required to initialize the Opy payment
* method. They can be omitted unless you need to support Opy.
Expand Down
3 changes: 0 additions & 3 deletions packages/core/src/payment/strategies/moneris/index.ts

This file was deleted.

This file was deleted.

Loading