Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/haproxy] Add externalIPs (#25564) #25565

Merged
merged 3 commits into from
May 7, 2024
Merged

[bitnami/haproxy] Add externalIPs (#25564) #25565

merged 3 commits into from
May 7, 2024

Conversation

olivierboudet
Copy link
Contributor

@olivierboudet olivierboudet commented May 6, 2024 •
edited by carrodher
Loading

Description of the change

Allows to set externalIPs on haproxy service.

Benefits

Allows to expose service with ExternalIPs

Fixes #25564

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added haproxy triage Triage is needed labels May 6, 2024
@github-actions github-actions bot requested a review from carrodher May 6, 2024 14:29
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels May 6, 2024
@github-actions github-actions bot removed the triage Triage is needed label May 6, 2024
@github-actions github-actions bot removed the request for review from carrodher May 6, 2024 17:14
@github-actions github-actions bot requested a review from jotamartos May 6, 2024 17:14
@jotamartos
Update bitnami/haproxy/Chart.yaml
7ba4c93 
Signed-off-by: Juan José Martos <[email protected]>
jotamartos
jotamartos approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@jotamartos jotamartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution.

@jotamartos jotamartos enabled auto-merge (squash) May 7, 2024 13:58
@jotamartos jotamartos merged commit 0a5acf9 into bitnami:main May 7, 2024
8 checks passed
matheusmgon pushed a commit to matheusmgon/charts that referenced this pull request May 8, 2024
@olivierboudet @bitnami-bot
@jotamartos @matheusmgon
[bitnami/haproxy] Add externalIPs (bitnami#25564) (bitnami#25565)
f5ab138 
* [bitnami/haproxy] Add externalIPs (bitnami#25564)

Signed-off-by: Olivier Boudet <[email protected]>

* Update README.md with readme-generator-for-helm

Signed-off-by: Bitnami Containers <[email protected]>

* Update bitnami/haproxy/Chart.yaml

Signed-off-by: Juan José Martos <[email protected]>

---------

Signed-off-by: Olivier Boudet <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Juan José Martos <[email protected]>
Co-authored-by: Bitnami Containers <[email protected]>
Co-authored-by: Juan José Martos <[email protected]>
Signed-off-by: Matheus Gonçalves <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jotamartos jotamartos jotamartos approved these changes

Assignees

@jotamartos jotamartos

Labels
haproxy solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bitnami/haproxy] Add ExternalIPs to Service
4 participants
@olivierboudet @jotamartos @carrodher @bitnami-bot