Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/haproxy] Add externalIPs (#25564) #25565

Merged
merged 3 commits into from
May 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bitnami/haproxy/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,4 @@ maintainers:
name: haproxy
sources:
- https://github.com/bitnami/charts/tree/main/bitnami/haproxy
version: 1.0.4
version: 1.1.0
1 change: 1 addition & 0 deletions bitnami/haproxy/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ As an alternative, use one of the preset configurations for pod affinity, pod an
| `service.loadBalancerIP` | haproxy service Load Balancer IP | `""` |
| `service.loadBalancerSourceRanges` | haproxy service Load Balancer sources | `[]` |
| `service.externalTrafficPolicy` | haproxy service external traffic policy | `Cluster` |
| `service.externalIPs` | External IPs | `[]` |
| `service.annotations` | Additional custom annotations for haproxy service | `{}` |
| `service.sessionAffinity` | Session Affinity for Kubernetes service, can be "None" or "ClientIP" | `None` |
| `service.sessionAffinityConfig` | Additional settings for the sessionAffinity | `{}` |
Expand Down
3 changes: 3 additions & 0 deletions bitnami/haproxy/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ spec:
{{- if .Values.service.clusterIP }}
clusterIP: {{ .Values.service.clusterIP }}
{{- end }}
{{- if .Values.service.externalIPs }}
externalIPs: {{- toYaml .Values.service.externalIPs | nindent 4 }}
{{- end }}
{{- if (or (eq .Values.service.type "LoadBalancer") (eq .Values.service.type "NodePort")) }}
externalTrafficPolicy: {{ .Values.service.externalTrafficPolicy | quote }}
{{- end }}
Expand Down
4 changes: 4 additions & 0 deletions bitnami/haproxy/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,10 @@ service:
## @param service.externalTrafficPolicy haproxy service external traffic policy
## ref https://kubernetes.io/docs/tasks/access-application-cluster/create-external-load-balancer/#preserving-the-client-source-ip
##
## @param service.externalIPs [array] External IPs
## ref: https://kubernetes.io/docs/concepts/services-networking/service/#external-ips
##
externalIPs: []
externalTrafficPolicy: Cluster
## @param service.annotations Additional custom annotations for haproxy service
##
Expand Down
Loading