Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/redis] Add option to change port name in master service #25579

Merged
merged 1 commit into from
May 9, 2024

Conversation

cwgthornton
Copy link
Contributor

Description of the change

Lets you specify the port.name in the service for the redis master service.

Benefits

If your kube instance requires the port's name to match the targetPort value, you can now use this chart.

Possible drawbacks

Not aware of any

Applicable issues

Additional information

NA

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added redis triage Triage is needed labels May 7, 2024
@github-actions github-actions bot requested a review from javsalgar May 7, 2024 18:36
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels May 7, 2024
@github-actions github-actions bot removed the triage Triage is needed label May 7, 2024
@github-actions github-actions bot removed the request for review from javsalgar May 7, 2024 21:21
@github-actions github-actions bot requested a review from dgomezleon May 7, 2024 21:21
Copy link
Member

@dgomezleon dgomezleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cwgthornton

Thanks for contributing. I added some minor suggestions to follow the same approach as RabbitMQ.

bitnami/redis/templates/master/service.yaml Outdated Show resolved Hide resolved
bitnami/redis/Chart.yaml Outdated Show resolved Hide resolved
Copy link
Member

@dgomezleon dgomezleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@dgomezleon dgomezleon merged commit 8e553bb into bitnami:main May 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
redis solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/redis] Ability to rename redis service port name
4 participants