Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/redis] Add option to change port name in master service #25579

Merged
merged 1 commit into from
May 9, 2024
Merged

[bitnami/redis] Add option to change port name in master service #25579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bitnami/redis/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ maintainers:
name: redis
sources:
- https://github.com/bitnami/charts/tree/main/bitnami/redis
version: 19.2.0
version: 19.3.0
3 changes: 2 additions & 1 deletion bitnami/redis/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,6 +584,7 @@ helm install my-release --set master.persistence.existingClaim=PVC_NAME oci://RE
| `master.persistentVolumeClaimRetentionPolicy.whenScaled` | Volume retention behavior when the replica count of the StatefulSet is reduced | `Retain` |
| `master.persistentVolumeClaimRetentionPolicy.whenDeleted` | Volume retention behavior that applies when the StatefulSet is deleted | `Retain` |
| `master.service.type` | Redis® master service type | `ClusterIP` |
| `master.service.portNames.redis` | Redis® master service port name | `tcp-redis` |
| `master.service.ports.redis` | Redis® master service port | `6379` |
| `master.service.nodePorts.redis` | Node port for Redis® master | `""` |
| `master.service.externalTrafficPolicy` | Redis® master service external traffic policy | `Cluster` |
Expand Down Expand Up @@ -1269,4 +1270,4 @@ Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
limitations under the License.
2 changes: 1 addition & 1 deletion bitnami/redis/templates/master/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ spec:
externalIPs: {{- include "common.tplvalues.render" (dict "value" .Values.master.service.externalIPs "context" $) | nindent 4 }}
{{- end }}
ports:
- name: tcp-redis
- name: {{ .Values.master.service.portNames.redis }}
port: {{ .Values.master.service.ports.redis }}
targetPort: redis
{{- if and (or (eq .Values.master.service.type "NodePort") (eq .Values.master.service.type "LoadBalancer")) .Values.master.service.nodePorts.redis}}
Expand Down
4 changes: 4 additions & 0 deletions bitnami/redis/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,6 +533,10 @@ master:
## @param master.service.type Redis® master service type
##
type: ClusterIP
## @param master.service.portNames.redis Redis® master service port name
##
portNames:
redis: "tcp-redis"
## @param master.service.ports.redis Redis® master service port
##
ports:
Expand Down
Loading