Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/valkey] Add new valkey chart #25643

Merged
merged 14 commits into from
May 10, 2024
Merged

[bitnami/valkey] Add new valkey chart #25643

merged 14 commits into from
May 10, 2024

Conversation

rafariossaa
Copy link
Contributor

@rafariossaa rafariossaa commented May 8, 2024 •
edited by javsalgar
Loading

Description of the change

This adds Valkey to the chart repository

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added the valkey label May 8, 2024
@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label May 8, 2024
@github-actions github-actions bot requested a review from andresbono May 8, 2024 13:27
@rafariossaa rafariossaa requested review from javsalgar and juan131 and removed request for andresbono May 8, 2024 13:27
@rafariossaa rafariossaa force-pushed the TAC26_valkey_chart branch 2 times, most recently from 1cf0649 to 87d2e63 Compare May 8, 2024 13:31
carrodher
carrodher reviewed May 8, 2024
View reviewed changes
bitnami/valkey/README.md Outdated Show resolved Hide resolved
bitnami/valkey/img/valkey-cluster-topology.png Outdated Show resolved Hide resolved
bitnami/valkey/templates/NOTES.txt Show resolved Hide resolved
This was referenced May 8, 2024
Closed
Open
juan131
juan131 requested changes May 9, 2024
View reviewed changes
Copy link
Contributor

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Please check muy comments.

.vib/valkey/ginkgo/valkey_suite_test.go Show resolved Hide resolved
bitnami/valkey/values.yaml Outdated Show resolved Hide resolved
.vib/valkey/runtime-parameters.yaml Outdated Show resolved Hide resolved
.vib/valkey/runtime-parameters.yaml Outdated Show resolved Hide resolved
bitnami/valkey/Chart.yaml Outdated Show resolved Hide resolved
bitnami/valkey/templates/replicas/application.yaml Outdated Show resolved Hide resolved
bitnami/valkey/templates/replicas/application.yaml Outdated Show resolved Hide resolved
bitnami/valkey/values.yaml Outdated Show resolved Hide resolved
bitnami/valkey/templates/servicemonitor.yaml Outdated Show resolved Hide resolved
bitnami/valkey/templates/servicemonitor.yaml Outdated Show resolved Hide resolved
@rafariossaa rafariossaa requested review from javsalgar and juan131 May 9, 2024 14:54
juan131
juan131 reviewed May 10, 2024
View reviewed changes
bitnami/valkey/README.md Outdated Show resolved Hide resolved
bitnami/valkey/templates/master/application.yaml Outdated Show resolved Hide resolved
bitnami/valkey/templates/_helpers.tpl Outdated Show resolved Hide resolved
@rafariossaa rafariossaa force-pushed the TAC26_valkey_chart branch from db63dc4 to 56a5842 Compare May 10, 2024 08:09
juan131
juan131 previously approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juan131
juan131 approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rafariossaa and others added 12 commits May 10, 2024 12:08
@rafariossaa
[bitnami/valkey] Initial valkey chart
937ea18 
Signed-off-by: Rafael Rios Saavedra <[email protected]>
@rafariossaa
Image for testing
e499df8 
Signed-off-by: Rafael Rios Saavedra <[email protected]>
@rafariossaa
Adds valkey-sentinel
e6f1760 
Signed-off-by: Rafael Rios Saavedra <[email protected]>
@rafariossaa
Fixes environment variable used for AUTH
07513de 
Signed-off-by: Rafael Rios Saavedra <[email protected]>
@rafariossaa
Adds valkey chart tests
907448c 
Signed-off-by: Rafael Rios Saavedra <[email protected]>
@rafariossaa
Update images versions, chart version, and fixes references to chart …
a4d771d 
…name in several files

Signed-off-by: Rafael Rios Saavedra <[email protected]>
@bitnami-bot @rafariossaa
Update README.md with readme-generator-for-helm
2039746 
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Rafael Rios Saavedra <[email protected]>
@rafariossaa
Removes valkey cluster related references as this not exists
bc059f3 
Signed-off-by: Rafael Rios Saavedra <[email protected]>
@rafariossaa
Fix review items
7b7954b 
Signed-off-by: Rafael Rios Saavedra <[email protected]>
@carrodher @rafariossaa
Update values.yaml
65d673a 
Signed-off-by: Rafael Rios Saavedra <[email protected]>
@rafariossaa
Some more fixes
3157138 
Signed-off-by: Rafael Rios Saavedra <[email protected]>
@rafariossaa
Fix autoscaling parameter reference in sentienl hpa
0261daf 
Signed-off-by: Rafael Rios Saavedra <[email protected]>
@rafariossaa rafariossaa force-pushed the TAC26_valkey_chart branch from 3efedc6 to 0261daf Compare May 10, 2024 10:09
juan131
juan131 previously approved these changes May 10, 2024
View reviewed changes
@rafariossaa
Fix port references in services
c696109 
Signed-off-by: Rafael Rios Saavedra <[email protected]>
@rafariossaa
Fix port label in ginko test
e669823 
Signed-off-by: Rafael Rios Saavedra <[email protected]>
@rafariossaa rafariossaa merged commit fae194a into bitnami:main May 10, 2024
8 checks passed
clarifai-fmarceau pushed a commit to clarifai-fmarceau/bitnami-charts that referenced this pull request May 30, 2024
@rafariossaa @bitnami-bot
@carrodher @clarifai-fmarceau
[bitnami/valkey] Add new valkey chart (bitnami#25643)
8475bc1 
* [bitnami/valkey] Initial valkey chart

Signed-off-by: Rafael Rios Saavedra <[email protected]>

* Image for testing

Signed-off-by: Rafael Rios Saavedra <[email protected]>

* Adds valkey-sentinel

Signed-off-by: Rafael Rios Saavedra <[email protected]>

* Fixes environment variable used for AUTH

Signed-off-by: Rafael Rios Saavedra <[email protected]>

* Adds valkey chart tests

Signed-off-by: Rafael Rios Saavedra <[email protected]>

* Update images versions, chart version, and fixes references to chart name in several files

Signed-off-by: Rafael Rios Saavedra <[email protected]>

* Update README.md with readme-generator-for-helm

Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Rafael Rios Saavedra <[email protected]>

* Removes valkey cluster related references as this not exists

Signed-off-by: Rafael Rios Saavedra <[email protected]>

* Fix review items

Signed-off-by: Rafael Rios Saavedra <[email protected]>

* Update values.yaml

Signed-off-by: Rafael Rios Saavedra <[email protected]>

* Some more fixes

Signed-off-by: Rafael Rios Saavedra <[email protected]>

* Fix autoscaling parameter reference in sentienl hpa

Signed-off-by: Rafael Rios Saavedra <[email protected]>

* Fix port references in services

Signed-off-by: Rafael Rios Saavedra <[email protected]>

* Fix port label in ginko test

Signed-off-by: Rafael Rios Saavedra <[email protected]>

---------

Signed-off-by: Rafael Rios Saavedra <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Co-authored-by: Bitnami Containers <[email protected]>
Co-authored-by: Carlos Rodríguez Hernández <[email protected]>
Signed-off-by: Francois Marceau <[email protected]>
@rafariossaa rafariossaa deleted the TAC26_valkey_chart branch August 7, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carrodher carrodher carrodher left review comments

@javsalgar javsalgar javsalgar left review comments

@juan131 juan131 juan131 approved these changes

Assignees

@javsalgar javsalgar

@juan131 juan131

@rafariossaa rafariossaa

Labels
bitnami solved valkey verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rafariossaa @javsalgar @juan131 @carrodher @andresbono @bitnami-bot