-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to >=py311 enum.StrEnum usage #1144
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1144 +/- ##
==========================================
- Coverage 91.29% 91.28% -0.01%
==========================================
Files 58 58
Lines 2941 2939 -2
==========================================
- Hits 2685 2683 -2
Misses 256 256 ☔ View full report in Codecov by Sentry. |
Are you sure about |
@trexfeathers Users can still type strings as before, so there's no difference in user experience or behaviour. When vs this ... TBH on reflection I prefer the former, so if you wanted to push a PR dropping the use of |
Ohhhh now I can't decide 😖
That's good!
That's bad!
Let me know if you're just being nice. If you really want it I will write it! |
@trexfeathers Let's go with reverting the use to |
🚀 Pull Request
Description
After adopting Scientific Python SPEC-0 and dropping support of
py310
, we're now free to adopt enum.StrEnum and enum.auto and thus purge some tech debt.