Use explicit strings in StrEnums #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trexfeathers
added
the
type: documentation
github-actions
bot
added
the
type: examples
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1152 +/- ##
=======================================
Coverage 91.28% 91.28%
=======================================
Files 58 58
Lines 2939 2939
=======================================
Hits 2683 2683
Misses 256 256 ☔ View full report in Codecov by Sentry. |
bjlittle
force-pushed
the
explicit_enums
branch
from
5da0480 to
83a3cde
Compare
bjlittle
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
@trexfeathers LGTM 🚀
Pushed a rebase on your pull-request to include the relevant changes on main i.e., #1155
Awesome, thanks 🥳
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
As discussed with @bjlittle, this ought to make the documentation clearer (#1144 (comment)).