Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing optional pyvistaqt package #497

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Handle missing optional pyvistaqt package #497

merged 1 commit into from
Oct 16, 2023

Conversation

bjlittle
Copy link
Owner

🚀 Pull Request

Description

Trap and re-raise ModuleNotFoundError instead of ImportError exception.


@github-actions github-actions bot added the type: testing Auto-labelled label Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #497 (1e621c6) into main (bcdb488) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #497   +/-   ##
=======================================
  Coverage   94.95%   94.95%           
=======================================
  Files         105      105           
  Lines        4484     4484           
=======================================
  Hits         4258     4258           
  Misses        226      226           
Files Coverage Δ
src/geovista/qt.py 100.00% <100.00%> (ø)
tests/test_qt.py 100.00% <100.00%> (ø)

@bjlittle bjlittle merged commit 9fc3b94 into main Oct 16, 2023
16 checks passed
@bjlittle bjlittle deleted the pyvistaqt-trap branch October 16, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: testing Auto-labelled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant