Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing optional pyvistaqt package #497

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Handle missing optional pyvistaqt package #497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/geovista/qt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

try:
import pyvistaqt as pvqt
except ImportError as e:
except ModuleNotFoundError as e:
e.msg = f'{e.msg} - please install the "pyvistaqt" and "pyqt" packages.'
raise

Expand Down
4 changes: 2 additions & 2 deletions tests/test_qt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ def test_pyvistaqt_import():
"""
try:
import pyvistaqt
except ImportError:
except ModuleNotFoundError:
pyvistaqt = False

if not pyvistaqt:
emsg = 'please install the "pyvistaqt" and "pyqt" packages'
with pytest.raises(ImportError, match=emsg):
with pytest.raises(ModuleNotFoundError, match=emsg):
import geovista.qt # noqa: F401


Expand Down
Loading