Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sex to names #456

Open
CodeWritingCow opened this issue Nov 6, 2017 · 0 comments
Open

Add sex to names #456

CodeWritingCow opened this issue Nov 6, 2017 · 0 comments
Labels
good first issue help wanted

Comments

@CodeWritingCow
Copy link
Collaborator

CodeWritingCow commented Nov 6, 2017 •
edited by arminkhoshbin
Loading

Add genders to existing names. Add new key-value pair "sex": "string" to JSON name files.

Use single, lowercase letters: m for male, f for female and u for unisex names. Don't spell out the whole words.

For example:

{
    "name": "Mary"
    "sex": "f", 
    "meaning": "Most likely Egyptian name derived in part from mry \"beloved\" or mr \"love\". Also known by Greek and Hebrew form of \"sea of bitterness\", \"rebelliousness\", and \"wished for child\"",
    ...
}

You can also:
@CodeWritingCow CodeWritingCow mentioned this issue Nov 6, 2017
Closed
CodeWritingCow added a commit to CodeWritingCow/name-db that referenced this issue Nov 10, 2017
@CodeWritingCow
Add sex to names - Issue bluzi#456
f7e1012
@CodeWritingCow CodeWritingCow mentioned this issue Nov 10, 2017
Merged
CodeWritingCow added a commit to CodeWritingCow/name-db that referenced this issue Nov 10, 2017
@CodeWritingCow
Add sex to names - Issue bluzi#456
6fafa92
bluzi pushed a commit that referenced this issue Nov 10, 2017
@CodeWritingCow @bluzi
Add sex to names (#467)
aca21bc 
* Add name "Jesus"

* Fix ISO language code

Use "cmn" for Chinese.

* Lowercase name

* Update 'Michael'

Add aliases and translation.
Merge "mitch" with "michael" because mitch is an alias for Michael.
Delete "mitch.json."

* Add gender to name file specs

Add gender to file specs in readme.md. Add tests to validate each JSON's
gender value.

* Update michael.json

Resolve merge conflict by using main repo's version of JSON file.

* Make sex field optional for now

Comment out tests for sex field. They are failing because names in
collection don't have that field. Issue #443

* Add tests to check validity of gender

Tests run only on name files that contain a gender value. Issue #443
Update README.md to describe sex field as optional.

* Update gender tests - Issue #443

Sex field now requires a value to pass test. Also:
- Add error messages to explain why a test failed.
- Remove test for checking whether a sex value is a string. It's
duplicating part of the "should have correct structure" test.

* Add sex to names - Issue #456

* Add sex to names - Issue #456
CodeWritingCow added a commit to CodeWritingCow/name-db that referenced this issue Nov 11, 2017
@CodeWritingCow
Add sex to 31 names
7d0a75b 
Issue bluzi#456
@CodeWritingCow CodeWritingCow mentioned this issue Nov 11, 2017
Merged
CodeWritingCow added a commit to CodeWritingCow/name-db that referenced this issue Nov 11, 2017
@CodeWritingCow
Add sex to 24 names
da1fdcf 
Issue bluzi#456
arminkhoshbin pushed a commit that referenced this issue Nov 11, 2017
@CodeWritingCow @arminkhoshbin
Add sex to names (#474)
ec34399 
* Add name "Jesus"

* Fix ISO language code

Use "cmn" for Chinese.

* Lowercase name

* Update 'Michael'

Add aliases and translation.
Merge "mitch" with "michael" because mitch is an alias for Michael.
Delete "mitch.json."

* Add gender to name file specs

Add gender to file specs in readme.md. Add tests to validate each JSON's
gender value.

* Update michael.json

Resolve merge conflict by using main repo's version of JSON file.

* Make sex field optional for now

Comment out tests for sex field. They are failing because names in
collection don't have that field. Issue #443

* Add tests to check validity of gender

Tests run only on name files that contain a gender value. Issue #443
Update README.md to describe sex field as optional.

* Update gender tests - Issue #443

Sex field now requires a value to pass test. Also:
- Add error messages to explain why a test failed.
- Remove test for checking whether a sex value is a string. It's
duplicating part of the "should have correct structure" test.

* Add sex to 31 names

Issue #456

* Add sex to 24 names

Issue #456
kevingorski added a commit to kevingorski/name-db that referenced this issue Dec 19, 2017
@kevingorski
bluzi#456 adding sex/gender to some names
677d334
chrisf pushed a commit that referenced this issue Jan 26, 2018
@kevingorski @chrisf
#456 adding sex/gender to some names (#489)
3bbb848
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CodeWritingCow