Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add balance calculation logic #419

Merged
merged 11 commits into from
Nov 26, 2024
Merged

Add balance calculation logic #419

merged 11 commits into from
Nov 26, 2024

Conversation

slavastartsev
Copy link
Contributor

@slavastartsev slavastartsev commented Nov 25, 2024 •
edited
Loading

Also includes updates to

  • estimateTxFee
  • createBitcoinPsbt

⚠️ Inputs that contain ordinals or runes no longer will be used in tx fee estimations or could be spent from (any, not just taproot) address

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: ccc36c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bob ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 3:12pm

@slavastartsev slavastartsev mentioned this pull request Nov 25, 2024
Merged
gregdhill
gregdhill reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@gregdhill gregdhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to have a test that checks the logic i.e. returns a smaller number if the address then holds ordinals. Maybe just alter the mocks to not return one of the UTXOs or something?

gregdhill
gregdhill reviewed Nov 26, 2024
View reviewed changes
sdk/test/utxo.test.ts Outdated Show resolved Hide resolved
@slavastartsev slavastartsev merged commit 9e92151 into master Nov 26, 2024
5 checks passed
@slavastartsev slavastartsev deleted the feat/utxo-ordinals branch November 26, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregdhill gregdhill gregdhill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slavastartsev @gregdhill