-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Amend v5.24.0 CHANGELOG entry #1209
Conversation
@@ -39,6 +39,7 @@ | |||
## 5.24.0 (2023-10-30) | |||
* BraintreePayPalDataCollector | |||
* Update PPRiskMagnes with 5.4.1 - staging removed (fixes #1107) | |||
* This version of the PPRiskMagnes framework is static |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure this is correct, v5 uses 5.4.1-stage-removed-xcode14-1
(Cartfile). Downloading that version from the assets and running file PPRiskMagnes
on both the simulator and non simulator files produces the expected dynamically linked outputs:
For static frameworks we would expect to see current ar archive
instead of Mach-O 64-bit dynamically linked shared library arm64
correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah exactly - iirc there was an issue with the version uploaded where it wasn't actually the correct magnes version at all (I think we brought this up to magnes as a reason that we should not host their SDK for them). Here is the PR: #1127. But yes, 5.24.1
is correct, and we have no idea what magnes version was in 5.24.0
because they don't include version numbers anywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the PR to call out the specific difference b/w the 2 versions!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the only way we can distinguish static vs dynamic framework dependency in our SDK?
I was trying to see the differences in versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For our dependency SDKs yes since they are not open source, for our own SDK we can look at the "Mach-O Type" in build settings.
Summary of changes
Checklist
Authors
@scannillo @agedd