Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Amend v5.24.0 CHANGELOG entry #1209

Merged
merged 2 commits into from
Mar 13, 2024
Merged

[main] Amend v5.24.0 CHANGELOG entry #1209

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6905e96
Update CHANGELOG.md
scannillo Mar 7, 2024
3e6f388
Update CHANGELOG.md
scannillo Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
## 5.24.1 (2023-11-17)
* BraintreePayPalDataCollector
* Update previously incorrect version of PPRiskMagnes 5.4.1 with staging removed
* This version of the PPRiskMagnes framework is dynamic

## 6.9.0 (2023-11-16)
* BraintreeThreeDSecure
Expand All @@ -39,6 +40,7 @@
## 5.24.0 (2023-10-30)
* BraintreePayPalDataCollector
* Update PPRiskMagnes with 5.4.1 - staging removed (fixes #1107)
* This version of the PPRiskMagnes framework is static
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this is correct, v5 uses 5.4.1-stage-removed-xcode14-1 (Cartfile). Downloading that version from the assets and running file PPRiskMagnes on both the simulator and non simulator files produces the expected dynamically linked outputs:
Screenshot 2024-03-07 at 10 30 04 AM

For static frameworks we would expect to see current ar archive instead of Mach-O 64-bit dynamically linked shared library arm64 correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 Good catch! OK, so it looks like 5.24.0 switched to static, and then 5.24.1 switches back to dynamic.

I checked this by checking out the tag version in the framework version local to the repo:
Screenshot 2024-03-07 at 4 57 33 PM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah exactly - iirc there was an issue with the version uploaded where it wasn't actually the correct magnes version at all (I think we brought this up to magnes as a reason that we should not host their SDK for them). Here is the PR: #1127. But yes, 5.24.1 is correct, and we have no idea what magnes version was in 5.24.0 because they don't include version numbers anywhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the PR to call out the specific difference b/w the 2 versions!

Copy link
Contributor

@KunJeongPark KunJeongPark Mar 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the only way we can distinguish static vs dynamic framework dependency in our SDK?
I was trying to see the differences in versions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For our dependency SDKs yes since they are not open source, for our own SDK we can look at the "Mach-O Type" in build settings.


## 6.8.0 (2023-10-24)
* BraintreeDataCollector
Expand Down
Loading