Deprecation Lines for BTPayPalNativeCheckout Module #1341
Conversation
KunJeongPark
changed the title
KunJeongPark
force-pushed
the
BTPayPalNativeCheckoutDeprecateMessage
branch
from
37fdd07 to
1a51dd5
Compare
CHANGELOG.md
Outdated
| * BraintreePayPalNativeCheckout | ||
| * Add deprecated warning in public classes and methods |
There was a problem hiding this comment.
| * BraintreePayPalNativeCheckout | |
| * Add deprecated warning in public classes and methods | |
| * BraintreePayPalNativeCheckout (DEPRECATED) | |
| * **Note:** This module is deprecated and will be removed in a future version of the SDK | |
| * Add deprecated warning message to all public classes and methods |
There was a problem hiding this comment.
Addressed here: 59485d6
| @@ -2,6 +2,7 @@ import Foundation | |||
| import UIKit | |||
| import BraintreePayPalNativeCheckout | |||
|
|
|||
| @available(*, deprecated, message: "BraintreePayPalNativeCheckout Module is deprecated, use BraintreePayPal Module instead") | |||
There was a problem hiding this comment.
This is our demo app, we don't need a deprecation message here, just in the public classes
There was a problem hiding this comment.
yes, but I got lint errors from referencing MXO classes here
There was a problem hiding this comment.
We don't have a linter on Braintree. Do you mean Cocoapods pod lib lint?
There was a problem hiding this comment.
yes. I think so. I saw a cocoapods test failure.
There was a problem hiding this comment.
https://github.com/braintree/braintree_ios/actions/runs/9614991255/job/26521134948
Oh maybe it was just the other non public classes and protocols that was causing the error.
I know on PPCP, I had failure without annotation on demo app files, so I conflated the two things.
I'll delete that line, I do see the lint warnings locally without that line there.
There was a problem hiding this comment.
Looks ok without the line there! Are we ok with the lint warning here?
There was a problem hiding this comment.
addressed here: 991982b
| @@ -37,6 +39,7 @@ import PayPalCheckout | |||
| self.nativeCheckoutProvider = nativeCheckoutProvider | |||
| } | |||
|
|
|||
| @available(*, deprecated, message: "BraintreePayPalNativeCheckout Module is deprecated, use BraintreePayPal Module instead") | |||
There was a problem hiding this comment.
We should move this one above the docstring instead of above the mark
There was a problem hiding this comment.
Great catch! Addressed here: 6e51baf
Summary of changes
@available(*, deprecated, message: "BraintreePayPalNativeCheckout Module is deprecated, use BraintreePayPal Module instead") for all public classes and enums for BraintreePayPalNativeCheckout module
Checklist
Authors