Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation Lines for BTPayPalNativeCheckout Module #1341

Merged
merged 8 commits into from
Jul 2, 2024
Merged

Deprecation Lines for BTPayPalNativeCheckout Module #1341

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
76c785f
deprecation lines for BTPayPalNativeCheckoutClient
KunJeongPark Jun 20, 2024
d05fc1a
add deprecate message for public functions
KunJeongPark Jun 20, 2024
1a51dd5
CHANGELOG
KunJeongPark Jun 20, 2024
fd589bb
add annotation on non public related classes to suppress lint errors
KunJeongPark Jun 21, 2024
59485d6
Jax PR feedback
KunJeongPark Jun 21, 2024
991982b
Jax PR feedback: remove annotation in demo app vc
KunJeongPark Jun 21, 2024
6e51baf
Jax PR feedback
KunJeongPark Jul 1, 2024
d978bfc
merge in main to resolve merge conflict on chagenlog
KunJeongPark Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
## unreleased
* BraintreeCore
* For analytics, only call `fetchOrReturnRemoteConfig()` when batch uploading, not on each analytic event enqueue
* BraintreePayPalNativeCheckout (DEPRECATED)
* **Note:** This module is deprecated and will be removed in a future version of the SDK
* Add deprecated warning message to all public classes and methods

## 6.21.0 (2024-06-12)
* BraintreePayPal
Expand Down
1 change: 1 addition & 0 deletions Sources/BraintreePayPalNativeCheckout/BTPayPalNativeCheckoutAccountNonce.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import BraintreePayPal

import PayPalCheckout

@available(*, deprecated, message: "BraintreePayPalNativeCheckout Module is deprecated, use BraintreePayPal Module instead")
/// Contains information about a PayPal payment method.
@objcMembers public class BTPayPalNativeCheckoutAccountNonce: BTPaymentMethodNonce {

Expand Down
6 changes: 6 additions & 0 deletions Sources/BraintreePayPalNativeCheckout/BTPayPalNativeCheckoutClient.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import BraintreePayPal

import PayPalCheckout

@available(*, deprecated, message: "BraintreePayPalNativeCheckout Module is deprecated, use BraintreePayPal Module instead")
/// Client used to collect PayPal payment methods. If possible, this client will present a native flow; otherwise, it will fall back to a web flow.
@objc public class BTPayPalNativeCheckoutClient: NSObject {

Expand All @@ -25,6 +26,7 @@ import PayPalCheckout
private let nativeCheckoutProvider: BTPayPalNativeCheckoutStartable


@available(*, deprecated, message: "BraintreePayPalNativeCheckout Module is deprecated, use BraintreePayPal Module instead")
/// Initializes a PayPal Native client.
/// - Parameter apiClient: The Braintree API client
@objc(initWithAPIClient:)
Expand All @@ -37,6 +39,7 @@ import PayPalCheckout
self.nativeCheckoutProvider = nativeCheckoutProvider
}

@available(*, deprecated, message: "BraintreePayPalNativeCheckout Module is deprecated, use BraintreePayPal Module instead")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should move this one above the docstring instead of above the mark

Copy link
Contributor Author

@KunJeongPark KunJeongPark Jul 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Addressed here: 6e51baf

// MARK: - Public Methods

/// Tokenize a PayPal request to be used with the PayPal Native Checkout flow.
Expand All @@ -56,6 +59,7 @@ import PayPalCheckout
tokenize(request: request, userAuthenticationEmail: request.userAuthenticationEmail, completion: completion)
}

@available(*, deprecated, message: "BraintreePayPalNativeCheckout Module is deprecated, use BraintreePayPal Module instead")
/// Tokenize a PayPal request to be used with the PayPal Native Checkout flow.
///
/// On success, you will receive an instance of `BTPayPalNativeCheckoutAccountNonce`.
Expand All @@ -77,6 +81,7 @@ import PayPalCheckout
}
}

@available(*, deprecated, message: "BraintreePayPalNativeCheckout Module is deprecated, use BraintreePayPal Module instead")
/// Tokenize a PayPal request to be used with the PayPal Native Vault flow.
///
/// On success, you will receive an instance of `BTPayPalNativeCheckoutAccountNonce`.
Expand All @@ -94,6 +99,7 @@ import PayPalCheckout
tokenize(request: request, completion: completion)
}

@available(*, deprecated, message: "BraintreePayPalNativeCheckout Module is deprecated, use BraintreePayPal Module instead")
/// Tokenize a PayPal request to be used with the PayPal Native Vault flow.
///
/// On success, you will receive an instance of `BTPayPalNativeCheckoutAccountNonce`.
Expand Down
1 change: 1 addition & 0 deletions Sources/BraintreePayPalNativeCheckout/BTPayPalNativeCheckoutError.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import Foundation
import PayPalCheckout

@available(*, deprecated, message: "BraintreePayPalNativeCheckout Module is deprecated, use BraintreePayPal Module instead")
/// Error returned from the native PayPal flow
public enum BTPayPalNativeCheckoutError: Error, CustomNSError, LocalizedError, Equatable {

Expand Down
1 change: 1 addition & 0 deletions Sources/BraintreePayPalNativeCheckout/BTPayPalNativeCheckoutProvider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import PayPalCheckout
import BraintreePayPal
#endif

@available(*, deprecated, message: "BraintreePayPalNativeCheckout Module is deprecated, use BraintreePayPal Module instead")
class BTPayPalNativeCheckoutProvider: BTPayPalNativeCheckoutStartable {

/// Used in POST body for FPTI analytics.
Expand Down
1 change: 1 addition & 0 deletions Sources/BraintreePayPalNativeCheckout/BTPayPalNativeCheckoutRequest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import BraintreeCore
import BraintreePayPal
#endif

@available(*, deprecated, message: "BraintreePayPalNativeCheckout Module is deprecated, use BraintreePayPal Module instead")
/// Options for the PayPal Checkout flow.
@objcMembers public class BTPayPalNativeCheckoutRequest: BTPayPalCheckoutRequest {

Expand Down
1 change: 1 addition & 0 deletions Sources/BraintreePayPalNativeCheckout/BTPayPalNativeCheckoutStartable.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import PayPalCheckout
import BraintreePayPal
#endif

@available(*, deprecated, message: "BraintreePayPalNativeCheckout Module is deprecated, use BraintreePayPal Module instead")
protocol BTPayPalNativeCheckoutStartable {

typealias StartableApproveCallback = (String?, User?) -> Void
Expand Down
1 change: 1 addition & 0 deletions Sources/BraintreePayPalNativeCheckout/BTPayPalNativeOrderCreationClient.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ struct BTPayPalNativeOrder: Equatable {
let orderID: String
}

@available(*, deprecated, message: "BraintreePayPalNativeCheckout Module is deprecated, use BraintreePayPal Module instead")
class BTPayPalNativeOrderCreationClient {

var payPalContextID: String? = nil
Expand Down
1 change: 1 addition & 0 deletions Sources/BraintreePayPalNativeCheckout/BTPayPalNativeTokenizationClient.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import BraintreePayPal

import PayPalCheckout

@available(*, deprecated, message: "BraintreePayPalNativeCheckout Module is deprecated, use BraintreePayPal Module instead")
class BTPayPalNativeTokenizationClient {

private let apiClient: BTAPIClient
Expand Down
1 change: 1 addition & 0 deletions Sources/BraintreePayPalNativeCheckout/BTPayPalNativeTokenizationRequest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import BraintreePayPal

import PayPalCheckout

@available(*, deprecated, message: "BraintreePayPalNativeCheckout Module is deprecated, use BraintreePayPal Module instead")
class BTPayPalNativeTokenizationRequest {

private let request: BTPayPalRequest
Expand Down
1 change: 1 addition & 0 deletions Sources/BraintreePayPalNativeCheckout/BTPayPalNativeVaultRequest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import BraintreeCore
import BraintreePayPal
#endif

@available(*, deprecated, message: "BraintreePayPalNativeCheckout Module is deprecated, use BraintreePayPal Module instead")
/// Options for the PayPal Vault flow.
@objcMembers public class BTPayPalNativeVaultRequest: BTPayPalVaultBaseRequest {

Expand Down
Loading