Pass Mutation Name as Endpoint for GraphQL #1349
Conversation
* fix constraints warning by adding leading and trailing constraints for nested stackViews * remove print statement
| let path = transaction.request.url?.path { | ||
| var path = transaction.request.url?.path { | ||
|
|
||
| if path.contains("graphql"), |
There was a problem hiding this comment.
Are we able to add a unit test for this?
There was a problem hiding this comment.
Sure, added: df95e39
| transactionMetrics.mockConnectStartDate = Date() | ||
| transactionMetrics.mockFetchStartDate = Date() |
There was a problem hiding this comment.
just curious, how are these two values different? 👀
There was a problem hiding this comment.
FetchStartDate: The time when the task started fetching the resource, from the server or locally.
ConnectStartDate: The time immediately before the task started establishing a TCP connection to the server.
Apple has an amazing graphic in their documentation that would explain it better. Apple doc reference
Thanks for asking. Yes, this change is part of something that was pending in another PR. Currently, we're sending the endpoint of all requests to measure latency. Since the GraphQL requests are the same, the suggestion was to send the name of the mutation to identify it. I'll share some PRs with you in case you want to dive deeper into this. Suggestion: #1321 (comment) |
Summary of changes
Checklist
Authors