Pass Mutation Name as Endpoint for GraphQL #1349
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -749,6 +749,36 @@ final class BTHTTP_Tests: XCTestCase { | |
| } | ||
| } | ||
| } | ||
|
|
||
| func testURLSessionTaskDidFinishCollectingMetrics() { | ||
| let mockDelegate = MockNetworkTimingDelegate() | ||
| http?.networkTimingDelegate = mockDelegate | ||
|
|
||
| var originalRequest = URLRequest(url: URL(string: "https://example.com/graphql")!) | ||
| originalRequest.httpBody = """ | ||
| { | ||
| "operationName": "TestMutation" | ||
| } | ||
| """.data(using: .utf8) | ||
| let task = testURLSession.dataTask(with: originalRequest) | ||
|
|
||
| let transactionMetrics = MockURLSessionTaskTransactionMetrics() | ||
| transactionMetrics.mockConnectStartDate = Date() | ||
| transactionMetrics.mockFetchStartDate = Date() | ||
|
Comment on lines
+766
to
+767
There was a problem hiding this comment. just curious, how are these two values different? 👀 There was a problem hiding this comment.
Apple has an amazing graphic in their documentation that would explain it better. Apple doc reference |
||
| transactionMetrics.mockResponseEndDate = Date().addingTimeInterval(1) | ||
| transactionMetrics.mockRequest = URLRequest(url: URL(string: "https://example.com/graphql")!) | ||
|
|
||
| let metrics = MockURLSessionTaskMetrics(transactionMetrics: [transactionMetrics]) | ||
|
|
||
| http?.urlSession(testURLSession, task: task, didFinishCollecting: metrics) | ||
|
|
||
| XCTAssertTrue(mockDelegate.didCallFetchAPITiming) | ||
| XCTAssertEqual(mockDelegate.receivedPath, "mutation TestMutation") | ||
| XCTAssertNotNil(mockDelegate.receivedConnectionStartTime) | ||
| XCTAssertNotNil(mockDelegate.receivedRequestStartTime) | ||
| XCTAssertNotNil(mockDelegate.receivedStartTime) | ||
| XCTAssertNotNil(mockDelegate.receivedEndTime) | ||
| } | ||
|
|
||
| // MARK: - Helper Methods | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| @testable import BraintreeCore | ||
| import Foundation | ||
|
|
||
| class MockNetworkTimingDelegate: BTHTTPNetworkTiming { | ||
| var didCallFetchAPITiming = false | ||
| var receivedPath: String? | ||
| var receivedConnectionStartTime: Int? | ||
| var receivedRequestStartTime: Int? | ||
| var receivedStartTime: Int? | ||
| var receivedEndTime: Int? | ||
|
|
||
| func fetchAPITiming(path: String, connectionStartTime: Int?, requestStartTime: Int?, startTime: Int, endTime: Int) { | ||
| didCallFetchAPITiming = true | ||
| receivedPath = path | ||
| receivedConnectionStartTime = connectionStartTime | ||
| receivedRequestStartTime = requestStartTime | ||
| receivedStartTime = startTime | ||
| receivedEndTime = endTime | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| import Foundation | ||
|
|
||
| class MockURLSessionTaskTransactionMetrics: URLSessionTaskTransactionMetrics { | ||
|
|
||
| var mockConnectStartDate: Date? | ||
| var mockFetchStartDate: Date? | ||
| var mockResponseEndDate: Date? | ||
| var mockRequest: URLRequest? | ||
|
|
||
| override var connectStartDate: Date? { | ||
| mockConnectStartDate | ||
| } | ||
|
|
||
| override var fetchStartDate: Date? { | ||
| mockFetchStartDate | ||
| } | ||
|
|
||
| override var responseEndDate: Date? { | ||
| mockResponseEndDate | ||
| } | ||
|
|
||
| override var request: URLRequest { | ||
| mockRequest ?? URLRequest(url: URL(string: "https://example.com")!) | ||
| } | ||
| } | ||
|
|
||
| class MockURLSessionTaskMetrics: URLSessionTaskMetrics { | ||
| var mockTransactionMetrics: [URLSessionTaskTransactionMetrics] | ||
|
|
||
| /// For testing only | ||
| init(transactionMetrics: [URLSessionTaskTransactionMetrics]) { | ||
| self.mockTransactionMetrics = transactionMetrics | ||
| } | ||
|
|
||
| override var transactionMetrics: [URLSessionTaskTransactionMetrics] { | ||
| mockTransactionMetrics | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we able to add a unit test for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, added: df95e39