Allow num_replica to be undefined #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation ---------- Capella defaults num_replica to 1 while Couchbase Server defaults to 0. Allowing num_replica to be undefined allows the user to use the default for their environment. Modifications ------------- Allow num_replica to be undefined and don't send in the index create or update query if it is undefined. Don't consider num_replica when resizing existing indices if it is undefined. Results ------- We are now more compatible with Capella behaviors. However, there is still one remaining issue. Capella will ignore num_replica = 0 on create and still create an index with one replica, causing the next sync to resize to zero replicas. However, num_replica = undefined will now behave consistently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Capella defaults num_replica to 1 while Couchbase Server defaults to 0.
Allowing num_replica to be undefined allows the user to use the default
for their environment.
Modifications
Allow num_replica to be undefined and don't send in the index create
or update query if it is undefined. Don't consider num_replica when
resizing existing indices if it is undefined.
Results
We are now more compatible with Capella behaviors. However, there is
still one remaining issue. Capella will ignore num_replica = 0 on
create and still create an index with one replica, causing the next
sync to resize to zero replicas. However, num_replica = undefined will
now behave consistently.