Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow num_replica to be undefined #125

Merged
merged 2 commits into from
Dec 31, 2023
Merged

Allow num_replica to be undefined #125

merged 2 commits into from
Dec 31, 2023

Commits on Dec 31, 2023

  1. Allow num_replica to be undefined 

    Motivation
----------
Capella defaults num_replica to 1 while Couchbase Server defaults to 0.
Allowing num_replica to be undefined allows the user to use the default
for their environment.

Modifications
-------------
Allow num_replica to be undefined and don't send in the index create
or update query if it is undefined. Don't consider num_replica when
resizing existing indices if it is undefined.

Results
-------
We are now more compatible with Capella behaviors. However, there is
still one remaining issue. Capella will ignore num_replica = 0 on
create and still create an index with one replica, causing the next
sync to resize to zero replicas. However, num_replica = undefined will
now behave consistently.
    @brantburnett
    brantburnett committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    b7356a8 View commit details
    Browse the repository at this point in the history

  2. Fixup some warnings

    @brantburnett
    brantburnett committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    3deadbb View commit details
    Browse the repository at this point in the history