Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(rust): improve docs for ockam enroll and ockam identity show #6213

Merged
merged 1 commit into from
Oct 3, 2023
Merged

docs(rust): improve docs for ockam enroll and ockam identity show #6213

merged 1 commit into from
Oct 3, 2023

Conversation

Salonikansal2
Copy link
Contributor

@Salonikansal2 Salonikansal2 commented Oct 2, 2023 •
edited
Loading

Current behavior

Proposed changes

Checks

  • All commits in this Pull Request are signed and Verified by Github.
  • All commits in this Pull Request follow the Ockam commit message convention.
  • There are no Merge commits in this Pull Request. Ockam repo maintains a linear commit history. We merge Pull Requests by rebasing them onto the develop branch. Rebasing to the latest develop branch and force pushing to your Pull Request branch is okay.
  • I have read and accept the Ockam Community Code of Conduct.
  • I have read and accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a separate Pull Request, this will mark the commit as verified.

@Salonikansal2 Salonikansal2 requested a review from a team as a code owner October 2, 2023 07:36
adrianbenavides
adrianbenavides reviewed Oct 2, 2023
View reviewed changes
Copy link
Member

@adrianbenavides adrianbenavides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Salonikansal2, thanks for putting your time in this PR 🙏

I've noticed you opened three different PR's with the same changes. Should we close them in favor of this one?

Also, could you include in the description the issue this PR is solving? If you write something like Fixes #{number-of-issue} it will track it automatically and will get closed when this PR gets merged.

Let me know if you have any question!

Salonikansal2
Salonikansal2 commented Oct 2, 2023
View reviewed changes
Copy link
Contributor Author

@Salonikansal2 Salonikansal2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #6053

Salonikansal2
Salonikansal2 commented Oct 2, 2023
View reviewed changes
Copy link
Contributor Author

@Salonikansal2 Salonikansal2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #6054

@Salonikansal2
Copy link
Contributor Author

Salonikansal2 commented Oct 2, 2023 •
edited
Loading

@adrianbenavides , I solved two issues but they kept merging into one pr that's why i tried so many times still i am not able to resolve this
Will this still be acceptable.
and yes please close the other two
(i tried changing branch like 10 times atleast).
Thanks for your time .

@Salonikansal2 Salonikansal2 changed the title Made changes in the message displayed fixes#6053 and fixes#6054 Made changes in the message displayed Oct 2, 2023
@mrinalwadhwa mrinalwadhwa added the hacktoberfest Apply to issues you want contributors to help with label Oct 2, 2023
This was referenced Oct 3, 2023
Closed
Closed
@adrianbenavides adrianbenavides changed the title fixes#6053 and fixes#6054 Made changes in the message displayed Fixes #6053 and 6129: made changes in the message displayed Oct 3, 2023
@adrianbenavides adrianbenavides changed the title Fixes #6053 and 6129: made changes in the message displayed docs(rust): improve docs for ockam enroll and ockam identity show Oct 3, 2023
@adrianbenavides adrianbenavides added the HACKTOBERFEST-ACCEPTED To be used when a PR is ready to merge or after it's merged label Oct 3, 2023
@adrianbenavides adrianbenavides self-requested a review October 3, 2023 11:54
adrianbenavides
adrianbenavides approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@adrianbenavides adrianbenavides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Salonikansal2 for your contribution 🙏
It will get merged ASAP 🚀

@Salonikansal2
Copy link
Contributor Author

Salonikansal2 commented Oct 3, 2023 •
edited
Loading

Thanku so much @adrianbenavides for your time and efforts in this pr. Really appreciate it. People like you and @mrinalwadhwa make open source so fun. Thanku 😇

@adrianbenavides adrianbenavides added this pull request to the merge queue Oct 3, 2023
@adrianbenavides adrianbenavides mentioned this pull request Oct 3, 2023
Closed
1 task
Merged via the queue into build-trust:develop with commit a051188 Oct 3, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianbenavides adrianbenavides adrianbenavides approved these changes

@SanjoDeundiak SanjoDeundiak SanjoDeundiak approved these changes

Assignees
No one assigned
Labels
hacktoberfest Apply to issues you want contributors to help with HACKTOBERFEST-ACCEPTED To be used when a PR is ready to merge or after it's merged
Projects
None yet
Milestone
No milestone
4 participants
@Salonikansal2 @SanjoDeundiak @adrianbenavides @mrinalwadhwa