Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add react v19 to peer deps #422

Merged
merged 1 commit into from
Oct 23, 2024
Merged

feat: add react v19 to peer deps #422

merged 1 commit into from
Oct 23, 2024

Conversation

Yonom
Copy link
Contributor

@Yonom Yonom commented Oct 22, 2024

Thanks a lot for this package

I get the following warning from pnpm after upgrading to NextJS v15 (released today), which installs react 19 RC

React 19 is technically still in RC stage, but since a stable version of a major Metaframework is installing it, it's a sign that it's ready for production use and will now be used by many projects.

└─┬ react-resizable-panels 2.1.4
  ├──  unmet peer react@"^16.14.0 || ^17.0.0 || ^18.0.0": found 19.0.0-rc-65a56d0e-20241020
  └──  unmet peer react-dom@"^16.14.0 || ^17.0.0 || ^18.0.0": found 19.0.0-rc-65a56d0e-20241020

Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-resizable-panels ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 0:39am

"react": "^16.14.0 || ^17.0.0 || ^18.0.0",
"react-dom": "^16.14.0 || ^17.0.0 || ^18.0.0"
"react": "^16.14.0 || ^17.0.0 || ^18.0.0 || ^19.0.0 || ^19.0.0-rc",
"react-dom": "^16.14.0 || ^17.0.0 || ^18.0.0 || ^19.0.0 || ^19.0.0-rc"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the ^19.0.0-rc bit may not be necessary. Is it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to support NextJS 15 which currently installs the RC, then it is necessary

You can test: https://semver.npmjs.com/

Screenshot 2024-10-22 at 15 58 40

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's interesting. I was testing using this tool which seemed to suggest that it was unnecessary. I guess it's safer to use the more conservative approach though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bvaughn The other data point is radix-ui using the same, see:
https://github.com/radix-ui/primitives/blob/main/packages/react/dialog/package.json#L49

I am not sure about the way the package managers handle this, but generally 19.0.0 is considered higher than 19.0.0-rc.x, so if you specify "^19.0.0", you wouldn't want 19.0.0-rc (which was released before 19.0.0) to be accepted

@bvaughn bvaughn merged commit 071ebc3 into bvaughn:main Oct 23, 2024
7 checks passed
@bvaughn
Copy link
Owner

bvaughn commented Oct 23, 2024

Thanks for the PR~

@Yonom Yonom deleted the react-19 branch October 23, 2024 23:31
@bvaughn
Copy link
Owner

bvaughn commented Oct 23, 2024

Dependencies updated in [email protected]


❤️ → ☕ givebrian.coffee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants