-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add react v19 to peer deps #422
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
"react": "^16.14.0 || ^17.0.0 || ^18.0.0", | ||
"react-dom": "^16.14.0 || ^17.0.0 || ^18.0.0" | ||
"react": "^16.14.0 || ^17.0.0 || ^18.0.0 || ^19.0.0 || ^19.0.0-rc", | ||
"react-dom": "^16.14.0 || ^17.0.0 || ^18.0.0 || ^19.0.0 || ^19.0.0-rc" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the ^19.0.0-rc
bit may not be necessary. Is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to support NextJS 15 which currently installs the RC, then it is necessary
You can test: https://semver.npmjs.com/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's interesting. I was testing using this tool which seemed to suggest that it was unnecessary. I guess it's safer to use the more conservative approach though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bvaughn The other data point is radix-ui using the same, see:
https://github.com/radix-ui/primitives/blob/main/packages/react/dialog/package.json#L49
I am not sure about the way the package managers handle this, but generally 19.0.0 is considered higher than 19.0.0-rc.x, so if you specify "^19.0.0", you wouldn't want 19.0.0-rc (which was released before 19.0.0) to be accepted
Thanks for the PR~ |
Dependencies updated in [email protected] ❤️ → ☕ givebrian.coffee |
Thanks a lot for this package
I get the following warning from pnpm after upgrading to NextJS v15 (released today), which installs react 19 RC
React 19 is technically still in RC stage, but since a stable version of a major Metaframework is installing it, it's a sign that it's ready for production use and will now be used by many projects.