Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add react v19 to peer deps #422

Merged
merged 1 commit into from
Oct 23, 2024
Merged

feat: add react v19 to peer deps #422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react-resizable-panels/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@
"react-dom": "experimental"
},
"peerDependencies": {
"react": "^16.14.0 || ^17.0.0 || ^18.0.0",
"react-dom": "^16.14.0 || ^17.0.0 || ^18.0.0"
"react": "^16.14.0 || ^17.0.0 || ^18.0.0 || ^19.0.0 || ^19.0.0-rc",
"react-dom": "^16.14.0 || ^17.0.0 || ^18.0.0 || ^19.0.0 || ^19.0.0-rc"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the ^19.0.0-rc bit may not be necessary. Is it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to support NextJS 15 which currently installs the RC, then it is necessary

You can test: https://semver.npmjs.com/

Screenshot 2024-10-22 at 15 58 40

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's interesting. I was testing using this tool which seemed to suggest that it was unnecessary. I guess it's safer to use the more conservative approach though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bvaughn The other data point is radix-ui using the same, see:
https://github.com/radix-ui/primitives/blob/main/packages/react/dialog/package.json#L49

I am not sure about the way the package managers handle this, but generally 19.0.0 is considered higher than 19.0.0-rc.x, so if you specify "^19.0.0", you wouldn't want 19.0.0-rc (which was released before 19.0.0) to be accepted

},
"browserslist": [
"Chrome 79"
Expand Down
Loading