Feat/refactor workflows #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: additional approval on Version change * fix: combine version bump check and approve by label * fix: adjust label name * fix: remove tag comparison * fix: base_ref * fix: some naming changes
jonathan-mayer
requested changes
Sep 12, 2024
|
|
github-actions
bot
added
the
needs approval
Fovty
requested changes
Sep 12, 2024
Fovty
reviewed
Sep 12, 2024
Fovty
previously approved these changes
Sep 13, 2024
jonathan-mayer
added
the
new release
github-actions
bot
removed
the
needs approval
JTaeuber
added a commit
that referenced
this pull request
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This pull request introduces an automatic release workflow for the GoKubeDownscaler.
Closes #41
Changes
I refactored our workflow files to first check the version on the main branch and then create a release and push the new helm chart and docker image for the GoKubeDownscaler.
Tests done
I tested these with a helm chart release workflow privately. You can look at them here.
TODO
Do NOT merge this until we want a release. This will create a release upon merge.