-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interpolated Looking implementation #4505
base: 1.19.4
Are you sure you want to change the base?
Conversation
Replaced old, in many cases not working "smoothlook" with "interpolatedLook", which forces global player rotation in both axis to follow a "path" from source looking position(rotation) to target, removing jittering when, for instance, mining blocks; it WILL hinder baritone's default mining speed, but the main purpose is to make actions seem slightly more humanly possible, time of the interpolation is controlled by interpolatedLookLength, in ticks.
8mb.video-4EL-9Jlk4hg4.mp4"showcase" video |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use google guidelines rn & dont commit the commented code
@@ -120,4 +121,8 @@ public static double entityDistanceToCenter(Entity entity, BlockPos pos) { | |||
public static double entityFlatDistanceToCenter(Entity entity, BlockPos pos) { | |||
return distanceToCenter(pos, entity.position().x, pos.getY() + 0.5, entity.position().z); | |||
} | |||
|
|||
public static Vec3 vDivide (Vec3 A, Vec3 B) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use google codestyle guidelines plz
if (this.target.mode == Target.Mode.SERVER) { | ||
ctx.player().setYRot(this.prevRotation.getYaw()); | ||
ctx.player().setXRot(this.prevRotation.getPitch()); | ||
}// else if (ctx.player().isFallFlying() && Baritone.settings().elytraSmoothLook.value) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is it? 💀. Commits the commented code is pretty bullshit
The interpolation is very cool, but given how abysmally slow the speed is you might want to 'boost' remainWithExistingLookDirection so it REALLY prefers to mine blocks in the existing look direction, to minimize turning. It looks more human anyway Or add some sort of penalty setting for it at least? |
Actually, having played around with this a bit, it's real nice. MUCH better and FASTER somehow than smoothlook, just have to nerf the ticks. It's nice! |
hey can you help me to compile with this changes? idk why it doesnt work when i do it :( im new in all this things |
Replaced old, in many cases not working "smoothlook" with "interpolatedLook", which forces global player rotation in both axis to follow a "path" from source looking position(rotation) to target, removing jittering when, for instance, mining blocks; it WILL hinder baritone's default mining speed, but the main purpose is to make actions seem slightly more humanly possible, time of the interpolation is controlled by interpolatedLookLength, in ticks.